search

google / git-appraise

Distributed code review system for Git repos
Apache License 2.0
5.12k stars 145 forks source link

Add documentation about how to specify line and column ranges for comments. #87

Closed kevinbarabash closed 5 years ago

kevinbarabash commented 5 years ago

Phabricator has this feature and it's really useful being able to pinpoint exactly what lines you're talking about when you make a comment.

ojarjur commented 5 years ago

This is already supported. The command is of the form:

git appraise comment -f <FILE-NAME> -l <START-LINE>(+<START-COLUMN>)?(:<END-LINE>+<END-COLUMN>)?

So, for example, to comment from between the 5th and 6th characters of the second line of file "foo.txt" to between the 7th and 8th characters of the fourth line, you would run:

git appraise comment -f foo.txt -l 2+5:4+7

However, looking through the code, it seems that this is not documented in either the help text or the README file.

We should add it to our docs.