google / gitiles

A simple browser for Git repositories.
https://gerrit.googlesource.com/gitiles/
Other
582 stars 174 forks source link

Bug: `getPredefinedDeviceProfiles` returns a single profile, that has all 0 in it #124

Closed AndroidDeveloperLB closed 6 years ago

AndroidDeveloperLB commented 6 years ago

About this: https://android.googlesource.com/platform/packages/apps/Launcher3/#

Inside the class InvariantDeviceProfile, when you call getPredefinedDeviceProfiles , it returns a list of a single item, and even then, it's faulty:

image

This causes a "arithmeticexception divide by zero" later, in DeviceProfile class, when the launcher tries to use the countX field, because it's 0 :

image

Please fix this.

AndroidDeveloperLB commented 6 years ago

Attached here the updated build.gradle file, because the one that's on the repo causes various building issues. build.zip

AndroidDeveloperLB commented 6 years ago

Oh it's the wrong repository. Sorry.