Link for symbolic link is broken

google / gitiles

A simple browser for Git repositories.

https://gerrit.googlesource.com/gitiles/

Other

582 stars 174 forks source link

Link for symbolic link is broken #144

Open jrn opened 6 years ago

jrn commented 6 years ago

https://android.googlesource.com/platform/hardware/interfaces/+/388897c3f20fcb05658ab6ef7168dc80866bb9d1/health/2.0/README

The README is a symbolic link to README.md in the same folder, but it actually links to .../health/2./README.md. The "0" is missing.

Keinkil commented 5 years ago

Any news on this?

sselberg commented 4 years ago

Seems like the general case is that: gitiles crops the last char in the next-to-last path component of the target when the symbolic link links to a file in the same sub-folder. Example. With file "abc/file.txt" and link "abc/linkedfile.txt -> abc/file.txt" gitiles interprets it as a link to "ab/file.txt".

sselberg commented 4 years ago

Fixed by: https://gerrit-review.googlesource.com/c/gitiles/+/277999