google / gitiles

A simple browser for Git repositories.
https://gerrit.googlesource.com/gitiles/
Other
578 stars 174 forks source link

Syntax highlighting does not support modern JavaScript features #198

Open TimvdLippe opened 4 years ago

TimvdLippe commented 4 years ago

For Chromium DevTools, we include JavaScript code snippets in our README (https://chromium.googlesource.com/devtools/devtools-frontend/+/218c5d61fbba8ee52e5a216f9b88490a5af7cdb0/test/e2e/README.md) but gitiles does not show the proper highlights for modern JavaScript features such as await.

Looking at the implementations of gitiles, it appears to use a custom Java port of prettify. Prettify does support these modern keywords: https://github.com/google/code-prettify/blob/453bd5f51e61245339b738b1bbdd42d7848722ba/js-modules/prettify.js#L150-L153

Could the Java prettify port be updated to reflect the new implementation of prettify.js?