Closed ilor closed 3 years ago
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!
and we'll verify it.
ℹ️ Googlers: Go here for more info.
I'm not sure why the CLA bot is complaining, I was under the impression the corporate CLA the email in the commit is covered by should be enough.
@googlebot I signed it!
Is this a fix for #151, and what will it take to get it merged?
This project doesn't take pull requests. See https://gerrit.googlesource.com/gitiles/+/HEAD/Documentation/developer-guide.md for contribution instructions.
Add image/svg+xml to the list of allowed mimetypes in ImageLoader, and also relax a check in HtmlBuilder because FilterImageDataUri from com.google.template.soy.shared.internal.EscapingConventions does not have svg on the allowed list, and it was rejecting the image data.
This is mostly a local hack I'm pushing for reference since the question of svg support pops up from time to time.