search

google / gitiles

A simple browser for Git repositories.
https://gerrit.googlesource.com/gitiles/
Other
578 stars 174 forks source link

gitiles fails to render HTML tables in Markdown content #228

Open bcmills opened 3 years ago

bcmills commented 3 years ago

Steps to reproduce

  1. Open https://go-review.googlesource.com/c/website/+/324489/1/_content/ref/mod.md#2824.
  2. Click the gitiles link in the diff header.
  3. Scroll to the section containing the new table.

Expected

Since HTML tables are not, to my knowledge, a grave security risk, the HTML table in the document should be rendered — in much the same way that GitHub renders the table below.

Name Command GOVCS default Secure schemes
Bazaar bzr Private only https, bzr+ssh
Fossil fossil Private only https
Git git Public and private https, git+ssh, ssh
Mercurial hg Public and private https, ssh
Subversion svn Private only https, svn+ssh

Observed

The table is dropped from the rendered document, without even any visual indication that content has been omitted.

image

bcmills commented 3 years ago

See previously #207, #219.

haruzheng commented 3 years ago

I think gitiles can't support html tag. I tried to <table>, <script>.

Finally i used markdown table.