google / gitiles

A simple browser for Git repositories.
https://gerrit.googlesource.com/gitiles/
Other
582 stars 174 forks source link

gitiles lacks responsive design #235

Open avm99963 opened 3 years ago

avm99963 commented 3 years ago

Gitiles isn't optimized for small screens (mobile, mainly). It would be awesome if we added responsive design so it adapts to small screens, what do you think?

I'd be willing to contribute changes towards this direction.

jrn commented 3 years ago

Sure, a CSS change to improve that would be welcome!

See https://gerrit.googlesource.com/gitiles/+/HEAD/Documentation/developer-guide.md for contribution instructions.

avm99963 commented 3 years ago

Awesome, I'll get to that soon then :)

avm99963 commented 2 years ago

I've made some progress in CLs 327080 and 327120. I'm not fully happy with the last one since it uses a CSS property which is not correctly implemented in Safari and has an accessibility issue, but I'm happy with sending the first one for review.

@jrn: I don't know how you do code review in the gitiles project, but if you're fine with that, I can add you as a reviewer of the first change.

These are some screenshots showing what's changed:

Before (current HEAD) After CL 327080
home_now home_responsive
repoindex_now repoindex_responsive
tree_now tree_responsive
file_now file_responsive
log_now log_responsive
doc_now doc_responsive

Also, here is a comparison of the commit page, which is improved in the 2nd CL:

Before (current HEAD) After CL 327080 After CL 327120
commit_now commit_responsive1 commit_responsive2