google / globalfoundries-pdk-ip-gf180mcu_fd_ip_sram

SRAM macros created for the GF180MCU provided by GlobalFoundries.
https://gf180mcu-pdk.rtfd.io
Apache License 2.0
16 stars 6 forks source link

Incorrect Address width in descriptions for 3 SRAM modules #10

Open shaos opened 1 year ago

shaos commented 1 year ago

Expected Behavior

gf180mcu_fd_ip_sramsram256x8m8wm1 should have A[7:0] gf180mcu_fd_ip_sram__sram512x8m8wm1 should have A[8:0] gf180mcu_fd_ip_sramsram64x8m8wm1 should have A[5:0]

Actual Behavior

in documentation all sram modules have A[6:0] as address description so it's correct only for sram128x8 (this is only documentation issue - in verilog everything looks ok)

Steps to Reproduce the Problem

Look into these 3 CSV files: cells/gf180mcu_fd_ip_sramsram256x8m8wm1/specs/1_pins_desc.csv:A[6:0],Input,"Address Input. This Address input port is used to cells/gf180mcu_fd_ip_sram__sram512x8m8wm1/specs/1_pins_desc.csv:A[6:0],Input,"Address Input. This Address input port is used to cells/gf180mcu_fd_ip_sramsram64x8m8wm1/specs/1_pins_desc.csv:A[6:0],Input,"Address Input. This Address input port is used to

Specifications

shaos commented 1 year ago

Initially noticed this problem here: https://gf180mcu-pdk.readthedocs.io/en/latest/IPs/ips.html

mithro commented 1 year ago

@atorkmabrains - Could you take a look?

atorkmabrains commented 1 year ago

@FaragElsayed2 Could you please review the documentation?

FaragElsayed2 commented 1 year ago

@atorkmabrains I have checked it

atorkmabrains commented 1 year ago

Thanks @FaragElsayed2