fix xschemrc - Githubissues

google / globalfoundries-pdk-libs-gf180mcu_fd_pr

Primitives for GF180MCU provided by GlobalFoundries.

https://gf180mcu-pdk.rtfd.io

Apache License 2.0

47 stars 25 forks source link

fix xschemrc #113

Closed curtisma closed 1 year ago

curtisma commented 1 year ago

Fixes #112

It also makes it more similar to the SKY130 xschemrc.

[x] Tests pass See "Testing" section below
[x] Appropriate changes to README are included in PR No changes to the README are required.

Testing

[x] the default schematic opens up when starting xschem without a schematic path provided
[x] test_nfet_0.v3.sch is successful:

google-cla[bot] commented 1 year ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

curtisma commented 1 year ago

Will someone please rerun the CLA check? I've now signed it.

curtisma commented 1 year ago

@proppy and @mithro, can you guys take a look and merge if this fix for the xschemrc is acceptable?

curtisma commented 1 year ago

I feel like there is a lot of repo layers for this to propagate through for it to end up fixing the original iic-osic-tools Issue #9

Merge this one
The gf180mcu PDK repo this is used in Why aren't each of the libraries just included in this repo. It seems like there will need to be a bump in this repo to get the update. Is this manual?
openpdks
iic-osic-tools

curtisma commented 1 year ago

so I just saw #112 which helps complement the issues fixed by this PR.

curtisma commented 1 year ago

cc: @atorkmabrains @StefanSchippers Let me know if you have any comments on these fixes

curtisma commented 1 year ago

@QuantamHD, you seem to have merged the last PR that was merged, can you take a look?

QuantamHD commented 1 year ago

Still seems like you're missing the CLA check. Other than a few minor questions. LGTM

StefanSchippers commented 1 year ago

Google says I have (already) signed the CLA. I have signed again. hope its ok

curtisma commented 1 year ago

@QuantamHD Can any of the 29 previous PRs be merged? A lot of them seem ready.

QuantamHD commented 1 year ago

I'll try to make my way through them. I'll merge this once the DRC passes.

QuantamHD commented 1 year ago

Are there any high priority PRs you need. A lot of them have merge conflicts or CI failures. I want to prioritize what's most important to you.

curtisma commented 1 year ago

Thanks for merging! @QuantamHD