Closed mithro closed 1 year ago
@mohanad0mohamed Could you please take care of this one soon?
@atorkmabrains This issue has been addressed in PV repo
This has been addressed in PV repo as highlighted by @FaragElsayed2
@mithro I'll close this issue. Please don't hesitate to open if you have any other concerns.
Expected Behavior
You shouldn't use
os.system
in Python scripts.Examples;
Should use python internal functionality;
https://github.com/google/globalfoundries-pdk-libs-gf180mcu_fd_pr/blob/2e2eb4ad16e9f26ae80f7b0cad70dfd9a10da177/rules/klayout/lvs/testing/run_sc_regression.py#L105
https://github.com/google/globalfoundries-pdk-libs-gf180mcu_fd_pr/blob/2e2eb4ad16e9f26ae80f7b0cad70dfd9a10da177/rules/klayout/lvs/testing/run_sc_regression.py#L139
Should use
subprocess
module;https://github.com/google/globalfoundries-pdk-libs-gf180mcu_fd_pr/blob/2e2eb4ad16e9f26ae80f7b0cad70dfd9a10da177/rules/klayout/lvs/testing/run_sc_regression.py#L138
Actual Behavior
You should use inbuilt Python functions or the
subprocess
module likecheck_call
orcheck_output
.Instead of using
rm
you should use something likePath.unlink
oros.unlink
orshutil.rmtree
.