Shouldn't use `os.system` in Python scripts

[mithro]

Expected Behavior

You shouldn't use os.system in Python scripts.

Examples;

Should use python internal functionality;

https://github.com/google/globalfoundries-pdk-libs-gf180mcu_fd_pr/blob/2e2eb4ad16e9f26ae80f7b0cad70dfd9a10da177/rules/klayout/lvs/testing/run_sc_regression.py#L105

https://github.com/google/globalfoundries-pdk-libs-gf180mcu_fd_pr/blob/2e2eb4ad16e9f26ae80f7b0cad70dfd9a10da177/rules/klayout/lvs/testing/run_sc_regression.py#L139

Should use subprocess module;

https://github.com/google/globalfoundries-pdk-libs-gf180mcu_fd_pr/blob/2e2eb4ad16e9f26ae80f7b0cad70dfd9a10da177/rules/klayout/lvs/testing/run_sc_regression.py#L138

Actual Behavior

You should use inbuilt Python functions or the subprocess module like check_call or check_output.

Instead of using rm you should use something like Path.unlink or os.unlink or shutil.rmtree.

[mithro]

https://github.com/google/globalfoundries-pdk-libs-gf180mcu_fd_pr/blob/2e2eb4ad16e9f26ae80f7b0cad70dfd9a10da177/rules/klayout/lvs/testing/run_sc_regression.py#L226

Should probably use https://docs.python.org/3/library/shutil.html?highlight=shutil#shutil.move or https://docs.python.org/3/library/os.html#os.rename or https://docs.python.org/3/library/os.html#os.replace

[atorkmabrains]

@mohanad0mohamed Could you please take care of this one soon?

[FaragElsayed2]

@atorkmabrains This issue has been addressed in PV repo

[atorkmabrains]

This has been addressed in PV repo as highlighted by @FaragElsayed2

@mithro I'll close this issue. Please don't hesitate to open if you have any other concerns.