google / globalfoundries-pdk-libs-gf180mcu_fd_pr

Primitives for GF180MCU provided by GlobalFoundries.
https://gf180mcu-pdk.rtfd.io
Apache License 2.0
47 stars 25 forks source link

consider using a test framework #79

Closed proppy closed 1 year ago

proppy commented 1 year ago

Expected Behavior

Tests should be using python testing best practices.

One popular framework is pytest: https://docs.pytest.org/en/7.2.x/ as it comes with:

Actual Behavior

Tests uses monolytics python scripts with manual exit() invocation, see https://github.com/google/globalfoundries-pdk-libs-gf180mcu_fd_pr/blob/main/rules/klayout/drc/testing/run_regression.py#L243

FaragElsayed2 commented 1 year ago

@atorkmabrains Did we hit this target in the new testing environment we have in PV repo ?

atorkmabrains commented 1 year ago

@FaragElsayed2 I don't believe so. I believe we still use the normal regression flow for PV. I recommend that we open another issue on PV repo and close this one.

FaragElsayed2 commented 1 year ago

@atorkmabrains Should I do that or wait for @proppy to move it ?

atorkmabrains commented 1 year ago

@FaragElsayed2 Please open the other issue on the PV repo and we I'll close that one. Please make sure to link the new issue to this issue.

FaragElsayed2 commented 1 year ago

@atorkmabrains Done

atorkmabrains commented 1 year ago

@FaragElsayed2 Could you please link it here?

FaragElsayed2 commented 1 year ago

Refer to https://github.com/google/globalfoundries-pdk-libs-gf180mcu_fd_pv/issues/76

Cc @atorkmabrains

atorkmabrains commented 1 year ago

@proppy I'm closing this issue as we moved it to PV repo as @FaragElsayed2 has highlighted above.