search

google / globalfoundries-pdk-libs-gf180mcu_fd_pr

Primitives for GF180MCU provided by GlobalFoundries.
https://gf180mcu-pdk.rtfd.io
Apache License 2.0
47 stars 25 forks source link

Adjusting Metal1 for symetrical CMOS Pcells. #83

Open christoph-weiser opened 1 year ago

christoph-weiser commented 1 year ago

Fixes #82

Change description

Adjusted Metal1 for the "right" side of the Pcell for both NMOS and PMOS. It appears a single statement was missing that caused both NMOS and PMOS devices to by asymmetrical.

Improvements

This bugfix is important because it is otherwise not possible to combine drain/source areas for multi finger transistors and also because Pcell generated devices should be symmetrical.

Tests

Hand selected measurements verifying the correct placement of Metal1 + DRC run using the ruleset from this repository.

google-cla[bot] commented 1 year ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

mithro commented 1 year ago

@mkkassem / @atorkmabrains - Who should review this change?

atorkmabrains commented 1 year ago

@mithro Me.

@christoph-weiser Could you please add screenshots before and after here to this PR?

christoph-weiser commented 1 year ago

Before

before

After

after

atorkmabrains commented 1 year ago

@christoph-weiser Thanks for the update. Looks great for me. Could you please create this PR on Efabless version of this repo? As the latest version is there.

atorkmabrains commented 1 year ago

Here please:

https://github.com/efabless/globalfoundries-pdk-libs-gf180mcu_fd_pr

atorkmabrains commented 1 year ago

@christoph-weiser It's advisable to actually open your PRs on: https://github.com/mabrains/globalfoundries-pdk-libs-gf180mcu_fd_pr rather than efabless version. As we do all the dev work in Mabrains version and we push releases to efabless version.

atorkmabrains commented 1 year ago

@FaragElsayed2 Could you please check if we have addressed this?

FaragElsayed2 commented 1 year ago

@atorkmabrains I will check that once I get the klayout Pcells back.

atorkmabrains commented 1 year ago

Thanks @FaragElsayed2

QuantamHD commented 1 year ago

Any chance you could rebase against head?

atorkmabrains commented 1 year ago

@FaragElsayed2 Could we rebase against main?

FaragElsayed2 commented 1 year ago

@atorkmabrains Rebase what ?

This branch christoph-weiser:cmos-pcell-fix ?

atorkmabrains commented 1 year ago

@FaragElsayed2 Yes, please. I think the Pcells has changed.

atorkmabrains commented 1 year ago

@QuantamHD I don't believe we can do this at our end.

@christoph-weiser Could you please rebase?