Closed FaragElsayed2 closed 1 year ago
@proppy Please review.
@proppy This fixes: #40
@atorkmabrains can you remove Draft
if it's ready for review?
Hi @atorkmabrains and @proppy
GlobalVars
: I believe we couldn't enable it as we have used some variables passed from klayout runUselessAssignment
: I think this rules will not be solvable as we use main runset as a wrapper for the other rule decks, so there are some variables are defined in main but used in the other runsets.Great work!
Maybe we could enable those two rules, and add expection on a per line basis with the following comments at the end of line that are doing this?
# rubocop:disable Lint/UselessAssignment Style/GlobalVars
Thanks @proppy
I was reviewing with Farag if we can do the suggestion above. But I believe it will be hard as we will have to add this comment all over the code.
Appreciate if we could keep it as disabled.
@proppy We appreciate if you could approve this as we need to move all the tables one by one here.
Sure thanks for working on this /cc @mithro
Enabling more restrictive rubocop rules in ruby linting
Style/FrozenStringLiteralComment
Metrics/MethodLength
RSpec/VariableName
Metrics/BlockNesting
Fixing #40