search

google / globalfoundries-pdk-libs-gf180mcu_fd_pv

Apache License 2.0
12 stars 6 forks source link

Adding LRES table for GF180MCU DRC #65

Closed FaragElsayed2 closed 1 year ago

FaragElsayed2 commented 1 year ago

Adding LRES table for GF180MCU DRC

Fixes #43

atorkmabrains commented 1 year ago

@proppy Looking forward to getting your feedback on all the PRs.

atorkmabrains commented 1 year ago

@proppy ?

proppy commented 1 year ago

@atorkmabrains can you review it first?

atorkmabrains commented 1 year ago

@proppy I have already reviewed and approved that code before. My concerns are different than yours. I always focus on 2 things:

All the code that you have here is already reviewed and approved multiple weeks before.

proppy commented 1 year ago

@atorkmabrains are you able to mark the PR as approved here?

atorkmabrains commented 1 year ago

@proppy Done

atorkmabrains commented 1 year ago

@proppy Are you using some form of automation to send those comments? I believe it seems that you are doing so. If yes, could you please enlighten me how you do that?

Also, are you doing some form of code scanners?

proppy commented 1 year ago

@proppy Are you using some form of automation to send those comments? I believe it seems that you are doing so. If yes, could you please enlighten me how you do that?

No, just way ETOOMANY many tabs open :)

Also, are you doing some form of code scanners?

My eyes and grep?