google / glog

C++ implementation of the Google logging module
http://google.github.io/glog/
BSD 3-Clause "New" or "Revised" License
6.93k stars 2.05k forks source link

feat: supports unicode paths #1069

Closed xfc1939 closed 6 months ago

xfc1939 commented 6 months ago

solved the questions about #998

xfc1939 commented 6 months ago

I used a marco that named GLOG_DEFINE_wstring in flags.cc, this marco defined in commandlineflags.h. It‘s ok on CMake, but it's failed on bazel. because it's used gflags/gflags.h on bazel. Have anyone give me a solution?

sergiud commented 6 months ago

Please do not create multiple PRs for the same issue because the comments are lost.

Let's continue in #998 where we left off.