search

google / glog

C++ implementation of the Google logging module
http://google.github.io/glog/
BSD 3-Clause "New" or "Revised" License
6.93k stars 2.05k forks source link

build(deps): bump codecov/codecov-action from 3 to 4 #1071

Closed dependabot[bot] closed 3 months ago

dependabot[bot] commented 5 months ago

Bumps codecov/codecov-action from 3 to 4.

Release notes

Sourced from codecov/codecov-action's releases.

v4.0.0

v4 of the Codecov Action uses the CLI as the underlying upload. The CLI has helped to power new features including local upload, the global upload token, and new upcoming features.

Breaking Changes

  • The Codecov Action runs as a node20 action due to node16 deprecation. See this post from GitHub on how to migrate.
  • Tokenless uploading is unsupported. However, PRs made from forks to the upstream public repos will support tokenless (e.g. contributors to OS projects do not need the upstream repo's Codecov token). This doc shows instructions on how to add the Codecov token.
  • OS platforms have been added, though some may not be automatically detected. To see a list of platforms, see our CLI download page
  • Various arguments to the Action have been changed. Please be aware that the arguments match with the CLI's needs

v3 versions and below will not have access to CLI features (e.g. global upload token, ATS).

What's Changed

... (truncated)

Changelog

Sourced from codecov/codecov-action's changelog.

4.0.0-beta.2

Fixes

  • #1085 not adding -n if empty to do-upload command

4.0.0-beta.1

v4 represents a move from the universal uploader to the Codecov CLI. Although this will unlock new features for our users, the CLI is not yet at feature parity with the universal uploader.

Breaking Changes

  • No current support for aarch64 and alpine architectures.
  • Tokenless uploading is unsuported
  • Various arguments to the Action have been removed

3.1.4

Fixes

  • #967 Fix typo in README.md
  • #971 fix: add back in working dir
  • #969 fix: CLI option names for uploader

Dependencies

  • #970 build(deps-dev): bump @​types/node from 18.15.12 to 18.16.3
  • #979 build(deps-dev): bump @​types/node from 20.1.0 to 20.1.2
  • #981 build(deps-dev): bump @​types/node from 20.1.2 to 20.1.4

3.1.3

Fixes

  • #960 fix: allow for aarch64 build

Dependencies

  • #957 build(deps-dev): bump jest-junit from 15.0.0 to 16.0.0
  • #958 build(deps): bump openpgp from 5.7.0 to 5.8.0
  • #959 build(deps-dev): bump @​types/node from 18.15.10 to 18.15.12

3.1.2

Fixes

  • #718 Update README.md
  • #851 Remove unsupported path_to_write_report argument
  • #898 codeql-analysis.yml
  • #901 Update README to contain correct information - inputs and negate feature
  • #955 fix: add in all the extra arguments for uploader

Dependencies

  • #819 build(deps): bump openpgp from 5.4.0 to 5.5.0
  • #835 build(deps): bump node-fetch from 3.2.4 to 3.2.10
  • #840 build(deps): bump ossf/scorecard-action from 1.1.1 to 2.0.4
  • #841 build(deps): bump @​actions/core from 1.9.1 to 1.10.0
  • #843 build(deps): bump @​actions/github from 5.0.3 to 5.1.1
  • #869 build(deps): bump node-fetch from 3.2.10 to 3.3.0
  • #872 build(deps-dev): bump jest-junit from 13.2.0 to 15.0.0
  • #879 build(deps): bump decode-uri-component from 0.2.0 to 0.2.2

... (truncated)

Commits


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
sergiud commented 5 months ago

@dependabot rebase

sergiud commented 3 months ago

@dependabot rebase

sergiud commented 3 months ago

@drigz We cannot update the Codecov action due to

Error: Codecov token not found. [...]

Codecov changed the way the secret is accessed requiring to setup the corresponding token explicitly (per project?). However, I don't have access to these settings. Is there someone from the organization who can set CODECOV_TOKEN as action secret for glog?

sergiud commented 3 months ago

@drigz Gentle ping. Any idea who can help here?

drigz commented 3 months ago

Thanks for the ping, I overlooked the first message. I'll take a look!

drigz commented 3 months ago

Codecov changed the way the secret is accessed requiring to setup the corresponding token explicitly (per project?).

How sure are you that this is the explanation? I can't see any internal references for Codecov token not found so I'm wondering if this is specific to this repo, for example if dependabot lacks access to the secret and so the action fails for this PR. In the Settings I can already see a per-project token:

image

Not sure how to verify that though, other than just merging and rolling back if we see other codecov failures. WDYT?

sergiud commented 3 months ago

Thanks for looking into this.

I'm sure about the explanation in the sense that I had the same problem with a couple of personal projects. I could fix the issue by deploying CODECOV_TOKEN under Dependabot repository secrets in addition to repository secrets under Actions:

image

drigz commented 3 months ago

I could fix the issue by deploying CODECOV_TOKEN under Dependabot repository secrets

Nice, thanks. I have copied the secret from https://app.codecov.io/gh/google/glog/settings to https://github.com/google/glog/settings/secrets/dependabot. Let's see if this helps.

drigz commented 3 months ago

@dependabot rebase

codecov-commenter commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 63.56%. Comparing base (2b36dfe) to head (283f635).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1071 +/- ## ========================================== + Coverage 60.52% 63.56% +3.03% ========================================== Files 19 19 Lines 2574 2566 -8 Branches 917 895 -22 ========================================== + Hits 1558 1631 +73 + Misses 676 674 -2 + Partials 340 261 -79 ``` [see 10 files with indirect coverage changes](https://app.codecov.io/gh/google/glog/pull/1071/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=google)
sergiud commented 3 months ago

@drigz This works. Thank you!