google / glog

C++ implementation of the Google logging module
http://google.github.io/glog/
BSD 3-Clause "New" or "Revised" License
6.93k stars 2.05k forks source link

Patch glog.bzl to fix wasm breakage #1082

Closed wzheng21 closed 4 months ago

wzheng21 commented 4 months ago

Currently, compiling glog to wasm would fail as described in Issue #1081 Root cause is the missing macros when compiling glog to wasm

Note that: this patch does not add CI/CD for wasm, but rather leaves it for future diff. The patch is tested on our company private development work.

google-cla[bot] commented 4 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.