search

google / glog

C++ implementation of the Google logging module
http://google.github.io/glog/
BSD 3-Clause "New" or "Revised" License
6.93k stars 2.05k forks source link

Register all log files with cleaner #1086

Open mturnock opened 4 months ago

mturnock commented 4 months ago

Ensures logs at other verbosity levels are cleaned up even if they are not logged

codecov-commenter commented 4 months ago

Codecov Report

Attention: Patch coverage is 89.85507% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 60.72%. Comparing base (31429d8) to head (b52e058).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1086 +/- ## ========================================== + Coverage 60.52% 60.72% +0.19% ========================================== Files 19 19 Lines 2574 2607 +33 Branches 917 933 +16 ========================================== + Hits 1558 1583 +25 - Misses 676 687 +11 + Partials 340 337 -3 ``` | [Files](https://app.codecov.io/gh/google/glog/pull/1086?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=google) | Coverage Δ | | |---|---|---| | [src/logging.cc](https://app.codecov.io/gh/google/glog/pull/1086?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=google#diff-c3JjL2xvZ2dpbmcuY2M=) | `68.57% <89.85%> (+0.17%)` | :arrow_up: |
mturnock commented 4 months ago

This implements the suggested registration approach. Any comments?

sergiud commented 4 months ago

Thanks for submitting the revised PR!

Unfortunately, I need some time to review the changes in detail.