Closed xppt closed 7 months ago
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
View this failed invocation of the CLA check for more information.
For the most up to date status, view the checks section at the bottom of the pull request.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 64.41%. Comparing base (
c0813f9
) to head (78484ce
).
Also, what's the output with your changes?
The stack trace contains module+offset line after patching:
@ 0x7fde6810f699 __cxa_throw
@ 0x55ce95d3d389 (/build/testbin-stripped+0x2388)
@ 0x55ce95d3d3c6 main
Thank you!
If the executable is stripped, I expect the
FailureSignalHandler
to dump module+offset for each stack frame, but the output is always(unknown)
. Seems like this is because of a typo inOpenObjectFileContainingPcAndGetStartAddress
.Code to reproduce: repro.zip Just extract and run
./run_test.py
on the host (docker and python3 are required).Expected output
Actual output