search

google / glog

C++ implementation of the Google logging module
http://google.github.io/glog/
BSD 3-Clause "New" or "Revised" License
7.01k stars 2.05k forks source link

Fix comment NOTE about SetVLOGLevel #1109

Open hari90 opened 3 months ago

hari90 commented 3 months ago

Fix the comment about SetVLOGLevel according to https://github.com/google/glog/pull/650 which added support for updating vmodule levels after vmodule level has been cached.

Fixes https://github.com/google/glog/issues/858

codecov-commenter commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 64.08%. Comparing base (45f99f5) to head (7e258ca).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1109 +/- ## ========================================== + Coverage 63.57% 64.08% +0.50% ========================================== Files 20 20 Lines 2578 2578 Branches 894 906 +12 ========================================== + Hits 1639 1652 +13 + Misses 671 662 -9 + Partials 268 264 -4 ``` [see 2 files with indirect coverage changes](https://app.codecov.io/gh/google/glog/pull/1109/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=google)
hari90 commented 3 months ago

Thanks for the PR.

Doesn't it make more sense to supply the updated information in the user guide, for instance, by updating this section?

I have put a basic description of SetVLOGLevel in the doc and more detailed information in the .h file. Let me know if this looks good enough.