search

google / glog

C++ implementation of the Google logging module
http://google.github.io/glog/
BSD 3-Clause "New" or "Revised" License
7.1k stars 2.07k forks source link

chore: add MODULE.bazel.lock to .gitignore #1120

Closed 4kangjc closed 3 months ago

drigz commented 3 months ago

How have you tested this?

I think https://github.com/google/glog/pull/1116 might be the better fix here - but if you've tested with wasm then this is the right place to change it.

4kangjc commented 3 months ago

How have you tested this?

I think #1116 might be the better fix here - but if you've tested with wasm then this is the right place to change it.

I think DHAVE_UNWIND and DHAVE_SYMBOLIZE are better together, they are stacktrace related macros, maybe it would be better to move them to linux_or_darwin_copts.

4kangjc commented 3 months ago

How have you tested this?

I think #1116 might be the better fix here - but if you've tested with wasm then this is the right place to change it.

I just saw #1116. #1116 can indeed solve #1111

drigz commented 3 months ago

I think DHAVE_UNWIND and DHAVE_SYMBOLIZE are better together, they are stacktrace related macros, maybe it would be better to move them to linux_or_darwin_copts.

I have no wasm dev environment and no one has contributed a CI test, so I'd lean towards only changing the options we can test.

4kangjc commented 3 months ago

I think DHAVE_UNWIND and DHAVE_SYMBOLIZE are better together, they are stacktrace related macros, maybe it would be better to move them to linux_or_darwin_copts.

I have no wasm dev environment and no one has contributed a CI test, so I'd lean towards only changing the options we can test.

OK. This PR is changed to only add MODULE.bazel.lock to .gitignore