google / glog

C++ implementation of the Google logging module
http://google.github.io/glog/
BSD 3-Clause "New" or "Revised" License
7.1k stars 2.07k forks source link

Fix symbolize detection on macOS #1138

Closed take-cheeze closed 2 weeks ago

take-cheeze commented 2 weeks ago

Since by detecting as UNIX first will end up as Linux: https://cmake.org/cmake/help/latest/variable/UNIX.html

codecov-commenter commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 63.73%. Comparing base (2075ae8) to head (77665b0).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1138 +/- ## ========================================== - Coverage 64.03% 63.73% -0.30% ========================================== Files 20 20 Lines 2580 2606 +26 Branches 888 903 +15 ========================================== + Hits 1652 1661 +9 - Misses 663 677 +14 - Partials 265 268 +3 ``` [see 9 files with indirect coverage changes](https://app.codecov.io/gh/google/glog/pull/1138/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=google)
take-cheeze commented 2 weeks ago

The warning message isn't printed in PR CI: https://github.com/google/glog/actions/runs/11684741346/job/32543647005?pr=1138#step:7:283 Master branch CI: https://github.com/google/glog/actions/runs/11361540607/job/31601487654#step:7:236

sergiud commented 2 weeks ago

Thanks!