search

google / gmail-oauth2-tools

Tools and sample code for authenticating to Gmail with OAuth2
Apache License 2.0
412 stars 211 forks source link

sendgmail: remove gmail domain check #46

Closed lollipopman closed 1 year ago

lollipopman commented 2 years ago

This program works correctly with Google Workspace accounts as well. So simply remove the check to ensure a gmail account is being used. This does mean folks from other providers will not be provided with an immediate error message, but the risk of confusion seems low considering the name of the repo is gmail-oauth2-tools.

lollipopman commented 2 years ago

This is an alternative to https://github.com/google/gmail-oauth2-tools/pull/26

rwuorinen81 commented 2 years ago

Please stop email me and messing around my account

On Mon, Jan 31, 2022, 11:41 AM Jesse Hathaway @.***> wrote:

This program works correctly with Google Workspace accounts as well. So simply remove the check to ensure a gmail account is being used. This does mean folks from other providers will not be provided with an immediate error message, but the risk of confusion seems low considering the name of the repo is gmail-oauth2-tools.

You can view, comment on, or merge this pull request online at:

https://github.com/google/gmail-oauth2-tools/pull/46 Commit Summary

File Changes

(1 file https://github.com/google/gmail-oauth2-tools/pull/46/files)

Patch Links:

— Reply to this email directly, view it on GitHub https://github.com/google/gmail-oauth2-tools/pull/46, or unsubscribe https://github.com/notifications/unsubscribe-auth/AS7J4OO63IR6YADBVEISFEDUY3CWDANCNFSM5NG5HN6A . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you are subscribed to this thread.Message ID: @.***>

lollipopman commented 2 years ago

any chance this could be reviewed?

junyer commented 1 year ago

Closing this in favour of commit e66a178.