search

google / gnostic-go-generator

A gnostic plugin that generates Go clients and servers for REST APIs
Apache License 2.0
48 stars 19 forks source link

port change: added error handling to golang plugin renderer #1

Closed noahdietz closed 5 years ago

noahdietz commented 5 years ago

Co-authored-by: Jon Glick 593022+glickbot@users.noreply.github.com

googlebot commented 5 years ago

So there's good news and bad news.

:thumbsup: The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

:confused: The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

googlebot commented 5 years ago

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

glickbot commented 5 years ago

+1, I confirm that I'm ok with my commits being contributed to this project.