google / gnostic-go-generator

A gnostic plugin that generates Go clients and servers for REST APIs
Apache License 2.0
49 stars 19 forks source link

Properly integrating types and methods of surface model #16

Closed LorenzHW closed 4 years ago

LorenzHW commented 4 years ago

Fixes #15

This PR adjusts this plugin to the types and methods received from the surface model:

LorenzHW commented 4 years ago

Here is a brief summary why this is necessary:

If I am not entirely mistaken gnostic-go-generator has not been working for v3 input files since the reimplementation of the surface model.

Also, for some weird reason CI did not run (just like in the PR we closed). However, I ran tests locally with no errors. WDYT?

noahdietz commented 4 years ago

If I am not entirely mistaken gnostic-go-generator has not been working for v3 input files since the reimplementation of the surface model.

Ah, makes sense to me.

Also, for some weird reason CI did not run (just like in the PR we closed).

I just reenabled CI in CircleCi. It should trigger on the next commit (there is no manual trigger capability, boo!).