google / gnostic-go-generator

A gnostic plugin that generates Go clients and servers for REST APIs
Apache License 2.0
49 stars 19 forks source link

Unify parameters styling between calls #35

Closed checorone closed 4 years ago

checorone commented 4 years ago

Client generation changes.

In a complex services there could be 10+ parameters for each call, and we don't want to pass all of them in a direct manner. Instead we suppose to use some sort of struct to collect all related call parameters together. By the way, there are already generated structs for it in the type.go file.

Oneline advantages of this PR :

Breaking change.

google-cla[bot] commented 4 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

checorone commented 4 years ago

@googlebot I signed it!

google-cla[bot] commented 4 years ago

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

timburks commented 4 years ago

@checorone Thanks for adding this! It makes sense and is what we usually see for Protocol Buffer-based APIs. I'll merge this and tag a new version.