qol Makefile and .gitignore adjustments

google / gnostic-go-generator

A gnostic plugin that generates Go clients and servers for REST APIs

Apache License 2.0

49 stars 19 forks source link

qol Makefile and .gitignore adjustments #5

Closed glickbot closed 5 years ago

glickbot commented 5 years ago

The makefiles (./Makefile & ./examples/**/Makefile) were all using 'go install github.com/googleapis/gnostic-go-generator', which (unless I'm mistaken) wouldn't test local changes unless you're working in $GOPATH/src/github.com/googleapis/gnostic-go-generator, so I tweaked the Makefiles to use relative directories instead.

Also added standard go .gitignore stuff from https://github.com/github/gitignore/blob/master/Go.gitignore, and added ".idea/*" (I usually use goland).

noahdietz commented 5 years ago

Looks fine to me, but just for my understanding, with this change, the examples/**/Makefile make build targets will run the make build target of the root directory Makefile?

glickbot commented 5 years ago

They will, they use 'make -C $(mkfile_dir)/../../../', mkfile_dir is their Makefile location, to call make on the root directory, which runs make based on it's mkfile_dir.