search

google / gnxi

gNXI Tools - gRPC Network Management/Operations Interface Tools
Apache License 2.0
260 stars 115 forks source link

gnoi_os.go install should have version as optional input #203

Closed Reshad-Rahman closed 4 years ago

Reshad-Rahman commented 4 years ago

Right now if version isn't provided the client exits: F0812 14:45:49.286570 16552 gnoi_os.go:80] No version provided. Provide one with -version Code is here: https://github.com/google/gnxi/blob/master/gnoi_os/gnoi_os.go#L80

But the version is optional: https://github.com/openconfig/gnoi/blob/master/os/os.proto#L139

samribeiro commented 4 years ago

Indeed, version should not be required for Install. Thanks for catching this.