Closed bartventer closed 3 months ago
Attention: Patch coverage is 0%
with 2 lines
in your changes are missing coverage. Please review.
Project coverage is 73.12%. Comparing base (
1f3e996
) to head (daa25e8
).
Files | Patch % | Lines |
---|---|---|
docstore/awsdynamodb/query.go | 0.00% | 1 Missing and 1 partial :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Fixes #3405
Although I was unable to reproduce the panic, I added a preventive check for
awsdynamodb
here. This check returnsio.EOF
if there are no more items, which should prevent anindex out of range
panic whenNext
is called after it has already returnedEOF
once.I also added a test case to verify this behavior. The test repeatedly calls
Next
until it getsio.EOF
, then callsNext
again to ensure it still returnsio.EOF
.I also generated new replay files for
awsdynamodb
andgcpfirestore
.