Closed peczenyj closed 1 month ago
Attention: Patch coverage is 85.71429%
with 3 lines
in your changes are missing coverage. Please review.
Project coverage is 73.31%. Comparing base (
9cc772b
) to head (c1a38e2
). Report is 3 commits behind head on master.
Files | Patch % | Lines |
---|---|---|
pubsub/rabbitpubsub/rabbit.go | 82.35% | 3 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I like the %v -> %w change, but not really the constant errors; they just seem like they add a level of indirection that makes the code less readable. Can you revert that change?
Done
I note that we mere add a %v reference to the original rabbitmq errors, and since we may need to unwrap such errors, it is better use %w
I also create few global errors to return instead allocate a new error in some trivial cases
Enjoy