search

google / go-cloud

The Go Cloud Development Kit (Go CDK): A library and tools for open cloud development in Go.
https://gocloud.dev/
Apache License 2.0
9.57k stars 812 forks source link

blob/s3blob: custom endpoints with s3 and aws sdk v2 #3473

Closed caarlos0 closed 3 months ago

caarlos0 commented 3 months ago

It seems that this is needed in aws-sdk-v2 for minio to work.

see: https://github.com/minio/docs/issues/406#issuecomment-1246316964 refs https://github.com/google/go-cloud/issues/3472

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 89.47368% with 2 lines in your changes missing coverage. Please review.

Project coverage is 73.14%. Comparing base (7a096fb) to head (39512fd). Report is 2 commits behind head on master.

Files Patch % Lines
aws/aws.go 89.47% 1 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3473 +/- ## ========================================== + Coverage 73.07% 73.14% +0.07% ========================================== Files 113 113 Lines 14979 14990 +11 ========================================== + Hits 10946 10965 +19 + Misses 3270 3261 -9 - Partials 763 764 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

SebouChu commented 3 months ago

Thanks @caarlos0!