search

google / go-cloud

The Go Cloud Development Kit (Go CDK): A library and tools for open cloud development in Go.
https://gocloud.dev/
Apache License 2.0
9.57k stars 812 forks source link

s3blob/blob: support additional endpoint query parameters #3486

Closed stanhu closed 2 months ago

stanhu commented 2 months ago

This commit adds the following query parameters for AWS:

  1. dualstack
  2. fips
  3. accelerate (S3-only)

This avoids the need for users to specify endpoint. For example, if my AWS S3 bucket is my-bucket in us-east-1, and you want to enable transfer acceleration, dual-stack support, and/or FIPS, you would need to configure endpoint with one of the following:

  1. my-bucket.s3-accelerate.amazonaws.com
  2. my-bucket.s3-accelerate.dualstack.amazonaws.com
  3. my-bucket.s3-fips.us-gov-east-1.amazonaws.com
  4. my-bucket.s3-fips.dualstack.us-east-1.amazonaws.com

For example, for the last option, users can use s3://my-bucket?fips=true&dualstack=true.

Closes https://github.com/google/go-cloud/issues/3484

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 73.45%. Comparing base (49a4d98) to head (602e83e). Report is 3 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3486 +/- ## ========================================== + Coverage 73.14% 73.45% +0.30% ========================================== Files 113 113 Lines 14983 15155 +172 ========================================== + Hits 10960 11132 +172 + Misses 3260 3258 -2 - Partials 763 765 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.