google / go-dap

Go implementation of the Debug Adapter Protocol

Apache License 2.0

127 stars 22 forks source link

Only emit GetSeq for ProtocolMessage, not all message types #43

Closed eliben closed 4 years ago

eliben commented 4 years ago

We don't actually need a GetSeq method on each message type. Since all messages embed ProtocolMessage, GetSeq on this type is sufficient. This is not breaking the API.

I verified this works by using the updated schematypes with delve/service/dap.

This should also simplify some of the discussion around #41 and #42

eliben commented 4 years ago

Travis build fails due to a test breakage #40 introduced.

45 fixes the failure, so it should go in before this PR