Fix failing server test

google / go-dap

Go implementation of the Debug Adapter Protocol

Apache License 2.0

127 stars 22 forks source link

Fix failing server test #45

Closed eliben closed 4 years ago

eliben commented 4 years ago

Test fails since #40 removed "omitempty" from allThreadsContinued, and the test expects hard-coded JSON strings for the responses.

eliben commented 4 years ago

It's really odd we didn't catch this in #40, maybe something is wrong with Travis.

polinasok commented 4 years ago

It doesn't look like we trigger build/test, do we? I don't see it in the UI for #40 (but maybe it goes away once the PR is merged), but I also don't see this for the pending PR #42. It just shows:

All checks have passed
1 successful check
cla/google — All necessary CLAs are signed

Travis dashboard was showing failures: https://travis-ci.org/github/google/go-dap/builds but no notifications were sent out, at least not to me.