Add default values for initialize request arguments

google / go-dap

Go implementation of the Debug Adapter Protocol

Apache License 2.0

127 stars 22 forks source link

Add default values for initialize request arguments #55

Closed suzmue closed 3 years ago

suzmue commented 3 years ago

The DAP spec includes that the default values for LinesStartAt1, ColumnsStartAt1 and PathFormat are nonzero values (true, true, and "path"). Set these values before decoding.

Additionally, remove the omitzero flags from LinesStartAt1 and ColumnsStartAt1, since this will not send the value if they are false.

eliben commented 3 years ago

@polinasok please also review

polinasok commented 3 years ago

FYI I tweaked the commit message a bit for clarity