search

google / go-flow-levee

Apache License 2.0
194 stars 18 forks source link

Update to dependency on golang.org/x/tools to v0.1.12. #327

Closed timothy-king closed 2 years ago

timothy-king commented 2 years ago

This prevents crashes on Go code containing generics. The standard library now contains generics at head and levee crashes for folks using newer toolchains.

See https://github.com/kubernetes/kubernetes/issues/111452.

Reflects running:

go get golang.org/x/tools@v0.1.12
go mod tidy

Fixes #326

timothy-king commented 2 years ago

I kind of feel like this should be folded into https://github.com/google/go-flow-levee/pull/325, so that PR doesn't need all the interface{} to any edits but could keep everything else (with or without the base 1.18 requirement).

I am not sure which order you are suggesting. This then #325. Or #325 then this?