google / go-github

Go library for accessing the GitHub v3 API
https://pkg.go.dev/github.com/google/go-github/v62/github
BSD 3-Clause "New" or "Revised" License
10.17k stars 2.02k forks source link

Codespaces #2362

Open josebalius opened 2 years ago

josebalius commented 2 years ago

I am planning on implementing support for Codespaces, see: https://docs.github.com/en/rest/codespaces

Using this issue to track that work. A couple of questions:

Thanks!

gmlewis commented 2 years ago
  • Do we prefer one large PR with the whole API implementation or multiple PRs?

I would prefer a bunch of smaller PRs if it is all the same with you.

  • Do we prefer to have multiple issues?

I'm fine with a single issue.

When we have a lot of things to work on, we often use checkboxes in a single issue like this:

etc... feel free to use them if you find it helpful to keep you organized. You are welcome to use this issue or open a new one. You can also go back and edit your first entry if you wish... totally up to you.

Thank you, @josebalius ! We appreciate your contributions!

gsmachado commented 1 year ago

@josebalius any progress on this?

josebalius commented 1 year ago

@gsmachado I started it but never really got into it much. Are you interested in taking over the issue or in the functionality?

gsmachado commented 1 year ago

@josebalius I'm developing something that would need the codespaces API. If I progress with the implementation directly on the go-github repo, I will submit a PR. 😄

gsmachado commented 1 year ago

@josebalius do you have any branch with your preliminary code?

josebalius commented 1 year ago

I have some code locally that I haven't pushed up. Are you interested in it?

artificial-aidan commented 1 year ago

Can you push up whatever you came up with?

artificial-aidan commented 1 year ago

I started with some simple implementation of codespace management. I'll post the punchlist below. Happy to split it into a new issue as well.

artificial-aidan commented 1 year ago
artificial-aidan commented 1 year ago

@gmlewis I have another branch for secret management, but still waiting on getting the CLA signed. Should I push that commit to the open PR I have, or just wait until I can get the first one merged.

gmlewis commented 1 year ago

Your call... whichever is most convenient for you. I'm fine either way.

artificial-aidan commented 1 year ago

The impact area was pretty small. I'll add them to the existing PR while waiting for CLA followup

KenSpur commented 1 year ago

Nice, also looking forward to this one. Its needed for the terraform provider

artificial-aidan commented 1 year ago

I got the CLA approved, just working through getting me added to it.