search

google / go-github

Go library for accessing the GitHub v3 API
https://pkg.go.dev/github.com/google/go-github/v65/github
BSD 3-Clause "New" or "Revised" License
10.34k stars 2.05k forks source link

Bug: Multi-select Custom Properties are not supported #3198

Closed darend closed 2 months ago

darend commented 3 months ago

Issue

The Github API supports organizational custom properties with the following types: string, single_select, multi_select, true_false. Creating a property with type multi_select or true_false breaks many of the library interactions due to unmarshalling errors

API Reference: https://docs.github.com/en/rest/orgs/custom-properties?apiVersion=2022-11-28#create-or-update-custom-properties-for-an-organization

Reproducing

gmlewis commented 3 months ago

Thank you, @darend. Would you like to create a PR, or shall I open this issue up to other contributors to this repo?

darend commented 3 months ago

@gmlewis , you can open to the community

gmlewis commented 3 months ago

This would be a great PR for any new contributor to this repo or a new Go developer. All contributions are greatly appreciated!

Feel free to volunteer for any issue and the issue can be assigned to you so that others don't attempt to duplicate the work.

Please check out our CONTRIBUTING.md guide to get started. (In particular, please remember to go generate ./... and don't use force-push to your PRs.)

Thank you!

arymoraes commented 3 months ago

This would be a great PR for any new contributor to this repo or a new Go developer. All contributions are greatly appreciated!

Feel free to volunteer for any issue and the issue can be assigned to you so that others don't attempt to duplicate the work.

Please check out our CONTRIBUTING.md guide to get started. (In particular, please remember to go generate ./... and don't use force-push to your PRs.)

Thank you!

@gmlewis I am a new Go developer and would like to volunteer to work on this issue if possible. Thank you!

gmlewis commented 3 months ago

@gmlewis I am a new Go developer and would like to volunteer to work on this issue if possible. Thank you!

Thank you, @arymoraes! It's yours.

gmlewis commented 3 months ago

Welcome to Go, @arymoraes! It's one of my favorite languages and I'm sure you will enjoy the experience after you spend a bit of time with it.

arymoraes commented 3 months ago

Welcome to Go, @arymoraes! It's one of my favorite languages and I'm sure you will enjoy the experience after you spend a bit of time with it.

Awesome, thank you. Looking forward for the experience!