search

google / go-github

Go library for accessing the GitHub v3 API
https://pkg.go.dev/github.com/google/go-github/v63/github
BSD 3-Clause "New" or "Revised" License
10.28k stars 2.04k forks source link

repository rulesets are missing the source attribute for the property condition #3247

Closed anelam closed 2 weeks ago

anelam commented 3 weeks ago

Rulesets have a source attribute for the property condition to select if a custom or system property is used. It is documented here.

It is missing in the RulesetRepositoryPropertyTargetParameters struct.

gmlewis commented 3 weeks ago

Thank you, @anelam .

Would you like to create a PR, or shall I open this up to other contributors to this repo?

anelam commented 3 weeks ago

@gmlewis feel free to open this up to others.

gmlewis commented 3 weeks ago

This would be a great PR for any new contributor to this repo or a new Go developer. All contributions are greatly appreciated!

Feel free to volunteer for any issue and the issue can be assigned to you so that others don't attempt to duplicate the work.

Please check out our CONTRIBUTING.md guide to get started. (In particular, please remember to go generate ./... and don't use force-push to your PRs.)

Thank you!

rezmoss commented 3 weeks ago

@gmlewis I'd like to work on this

gmlewis commented 3 weeks ago

@gmlewis I'd like to work on this

Thank you, @rezmoss ! It's yours.