search

google / go-jsonnet

Apache License 2.0
1.63k stars 235 forks source link

feat: implement std.round #683

Closed rohitjangid closed 1 year ago

rohitjangid commented 1 year ago

Add std.round function in standard library.

PR for jsonnet: https://github.com/google/jsonnet/pull/1064

rohitjangid commented 1 year ago

@sparkprime Can you help me understand why these checks are failing? By looking at error messages, it looks like it something is failing in go sdk.

sparkprime commented 1 year ago

there's something going on but also i think there's a trailing newline diff with your golden files. go test --update will fix that. However I'm just going to merge it and sort it all out myself because of the other issue.