google / go-jsonnet

Apache License 2.0
1.63k stars 235 forks source link

Teach jsonnet-lint about optional parameters of std.manifestYamlDoc #705

Closed swgillespie closed 1 year ago

swgillespie commented 1 year ago

manifestYamlDoc takes two optional parameters, indent_array_in_object and quote_keys. This commit teaches jsonnet-lint about them so that it doesn't raise errors when you use them.

There are other stdlib library functions with this problem; the true solution is probably to auto-generate this from the stdlib AST, but this at least gets the linter happy with this particular function.

google-cla[bot] commented 1 year ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

sparkprime commented 1 year ago

There is also the documentation which exists as a jsonnet file and I believe lists the params.