google / go-jsonnet

Apache License 2.0
1.63k stars 235 forks source link

gazelle naming convention changes #717

Open lijunsong opened 1 year ago

lijunsong commented 1 year ago

Hello, go-jsonnet is still using gazelle 0.26, which generates old-style BUILD target names. For projects using newer gazelle, the default naming convention for go-jsonnet is "@com_github_google_go_jsonnet//:go-jsonnet".

Of course a small tune is possible: simply tune the build_naming_convention argument:

    go_repository(
        name = "com_github_google_go_jsonnet",
        build_naming_convention = "go_default_library",
        importpath = "github.com/google/go-jsonnet",
        sum = "h1:WG4TTSARuV7bSm4PMB4ohjxe33IHT5WVTrJSU33uT4g=",
        version = "v0.20.0",
    )

A better fix would be similar to https://github.com/google/rpmpack/pull/59, upgrade gazelle, generate the BUILD file again.