search

google / go-jsonnet

Apache License 2.0
1.61k stars 231 forks source link

Fix interface conversion from int types to float64 #741

Closed shrdlu68 closed 3 months ago

google-cla[bot] commented 8 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

suzuki-shunsuke commented 4 months ago

Can we get a chance to review this pull request? I wrote an issue about this pull request.

suzuki-shunsuke commented 4 months ago

I'm trying this pull request, but this doesn't work as expected. panic doesn't occur but the return value is always 0.

sbarzowski commented 3 months ago

Closing in favour of https://github.com/google/go-jsonnet/pull/753