google / go-licenses

A lightweight tool to report on the licenses used by a Go package and its dependencies. Highlight! Versioned external URL to licenses can be found at the same time.
Apache License 2.0
833 stars 125 forks source link

Add include_tests flag for deps only used in tests #160

Closed davidhsingyuchen closed 2 years ago

davidhsingyuchen commented 2 years ago

PR fixes #62. PR is based on the work of @blanet.

Bobgy commented 2 years ago

Thank you! Can we get @blanet's consent?

blanet commented 2 years ago

Oh, I'm sorry for being offline for so long. It's great that @davidhsingyuchen picked up my old work and fell free to base on them if they can help. I'm totally consent with this @Bobgy .

Bobgy commented 2 years ago

@davidhsingyuchen can you fix the test?

davidhsingyuchen commented 2 years ago

@Bobgy Thanks for the reminder. make precommit exits with 0 now.

davidhsingyuchen commented 2 years ago

@Bobgy Thank you for the review! I try to follow the other sections in README to explain why this flag may be useful. Please let me know if the tone sounds good to you, thanks!