search

google / go-sev-guest

go-sev-guest offers a library to wrap the /dev/sev-guest device in Linux, as well as a library for attestation verification of fundamental components of an attestation report.
Apache License 2.0
45 stars 19 forks source link

Use pre-generated local private keys for default AMD keys #130

Closed yawangwang closed 1 month ago

yawangwang commented 2 months ago

Load local ECDSA private keys instead of using ecdsa.GenerateKey because the underlying implementations will cause our internal test environment crash.

deeglaze commented 2 months ago

Have you verified that these changes stop your test from crashing?

yawangwang commented 1 month ago

Have you verified that these changes stop your test from crashing?

Though those changes cannot stop my test from crashing, it might be a good practice to use the pre-generated test private keys to make tests run faster.

yawangwang commented 1 month ago

ooops looks like the PR merging policy is a bit different from go-tpm-tools, sending 1 reapproval request to @deeglaze