Adding support for setting java system properties (go-tika #15)

google / go-tika

Go package for using Apache Tika

Apache License 2.0

229 stars 40 forks source link

Adding support for setting java system properties (go-tika #15) #16

Closed dmnyu closed 4 years ago

dmnyu commented 4 years ago

This pull requests

Adds a javaprops map to Server
Adds a AddJavaProp function to add key-value pairs to a Servers javaprops map
Modifies the Start() function to check if the javaprops map is not empty, if so it formats key value pairs into system property setters to the java command.
Adds a test to check that kv pairs are being added to javaprops map

dmnyu commented 4 years ago

That makes a lot of sense. I'll make the changes.

dmnyu commented 4 years ago

Thanks Tyler,

I made all of the changes in my local repo and just need to update the comments and documentation. It probably goes without saying how crazy things are atm.

Don

tbpg commented 4 years ago

Sounds good -- totally understand. No rush.

tbpg commented 4 years ago

Merging and will send another PR for a few style changes.

Thank you!

dmnyu commented 4 years ago

Tyler, Thanks for all the help. this was the first PR I've done for a Go project.

tbpg commented 4 years ago

Thank you for the contribution! And welcome! :tada: