google / go-tpm-tools

Go packages built on go-tpm providing a high-level API for using TPMs
Apache License 2.0
231 stars 71 forks source link

Remove the x86 build/test from the CI. #495

Open qinkunbao opened 1 month ago

qinkunbao commented 1 month ago

Remove the x86 build/test from the CI from the CI for the following reasons.

  1. Our CVMs only support x86-64.
  2. Some dependency libraries (go-tdx-guest, go-sev-guest) are only tested with x86-64.
  3. go-tpm-tools releases only have x86-64.
JoshuaKrstic commented 1 month ago

/gcbrun

jkl73 commented 1 month ago

CVM is not the only platform this tool/lib can run. Majority features on gotpm cli and libs are not depending on go-tdx-guest/go-sev-guest Users may still want to build the binary on a 32 bit system.

jkl73 commented 1 month ago

So I think we probably should keep x86 build/test in CI, unless it's so broken and beyond fix.