google / goexpect

Expect for Go
BSD 3-Clause "New" or "Revised" License
759 stars 134 forks source link

fix typos in README and import package name intuitive #12

Closed wilbeibi closed 6 years ago

googlebot commented 6 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


wilbeibi commented 6 years ago

I signed it!

googlebot commented 6 years ago

CLAs look good, thanks!

skalle commented 6 years ago

Soo sorry about the late reply here.. I obviously have messed up either notifications and/or my mail filters.

Added a comment in the review.

wilbeibi commented 6 years ago

Ohh, I should close this PR. I was sending PR only about typo.

Since got no response, I was keep modifying for my own usage, and didn't notice the later changes keep showing in PR.

So my changes for logrus should not be here (sorry).