search

google / goexpect

Expect for Go
BSD 3-Clause "New" or "Revised" License
759 stars 134 forks source link

Add circleci CI #38

Closed marco-m closed 5 years ago

marco-m commented 5 years ago

Hello,

this is in the same spirit of https://github.com/google/goterm/pull/4.

You can have a look at the current status of the build of my fork at https://circleci.com/gh/marco-m/goexpect/5.

If I understand correctly, there are some tests that require a TCP process around, see for example:

E0407 14:38:44.511598    2580 expect_test.go:137] Accept failed: accept tcp [::]:39922: use of closed network connection

If this is the case, I can have a look at this.

To make the build green I had to fix examples/process/process.go. I also added the build badge to the README.

To make this work, in your account on https://circleci.com (github credentials), go to "Add Projects", select your goexpect repo and enable building.

skalle commented 5 years ago

Hey Marco.

Appreciated! .. Really like CircleCI. Thx!

marco-m commented 5 years ago

Hello @skalle, yes, CircleCI is really good.