fix SpawnFake session ending

JulienVdG commented 5 years ago

This was detected by using Tee and checking if the Tee Close function was called. It was not ... adding the srv.Close() call made waitForSession end (the <-endch whould no lomger block). But the Tee Close function was called twice, because the batcher srv is also using Tee while it should not.

Signed-off-by: Julien Viard de Galbert julien.viard-de-galbert@itrenew.com

googlebot commented 5 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

skalle commented 5 years ago

What's up with the CLA signing?

JulienVdG commented 5 years ago

ITRENEW's Chief Financial Officer who is responsible for legal too signed it, but apparently the CLA was voided pretending he does not have the right position... I wrote to cla-submissions to try to sort this out. Maybe you can help ?

JulienVdG commented 5 years ago

We filed the CLA again with some changes to the point of contact and it was accepted so:

We signed it!

googlebot commented 5 years ago

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

skalle commented 5 years ago

Thx. for making GoExpect better!

JulienVdG commented 5 years ago

Thanks for making/maintaining GoExpect. :) I'm using it for a test framework (https://github.com/JulienVdG/tastevin/) so expect new PR when I continue using GoExpect !

google / goexpect